Help TMA Bands Indicator
Created at 16 Jun 2021, 16:59
Help TMA Bands Indicator
16 Jun 2021, 16:59
Hi All,
i would like to have help please, i am trying to recode an TMA (Triangular Moving Average) Bands Inndicator from MT4 i have found but i am not able to do it.
Here the MT4 Code :
#property copyright "mladen"
#property link "mladenfx@gmail.com"
#property indicator_chart_window
#property indicator_buffers 3
#property indicator_color1 LimeGreen
#property indicator_color2 Red
#property indicator_color3 Green
#property indicator_style2 STYLE_DOT
#property indicator_style3 STYLE_DOT
extern string TimeFrame = "current time frame";
extern int HalfLength = 56;
extern int Price = PRICE_CLOSE;
extern double ATRMultiplier = 2.0;
extern int ATRPeriod = 100;
extern bool Interpolate = true;
extern bool alertsOn = true;
extern bool alertsOnCurrent = false;
extern bool alertsOnHighLow = true;
extern bool alertsMessage = true;
extern bool alertsSound = false;
extern bool alertsEmail = false;
double buffer1[];
double buffer2[];
double buffer3[];
double trend[];
string indicatorFileName;
bool calculateValue;
bool returnBars;
int timeFrame;
//+------------------------------------------------------------------+
//| |
//+------------------------------------------------------------------+
int init()
{
IndicatorBuffers(4);
HalfLength=MathMax(HalfLength,1);
SetIndexBuffer(0,buffer1); SetIndexDrawBegin(0,HalfLength);
SetIndexBuffer(1,buffer2); SetIndexDrawBegin(1,HalfLength);
SetIndexBuffer(2,buffer3); SetIndexDrawBegin(2,HalfLength);
SetIndexBuffer(3,trend);
//
indicatorFileName = WindowExpertName();
returnBars = TimeFrame=="returnBars"; if (returnBars) return(0);
calculateValue = TimeFrame=="calculateValue"; if (calculateValue) return(0);
timeFrame = stringToTimeFrame(TimeFrame);
//
IndicatorShortName(timeFrameToString(timeFrame)+" TMA bands )"+HalfLength+")");
return(0);
}
int deinit() { return(0); }
//+------------------------------------------------------------------+
//| |
//+------------------------------------------------------------------+
int start()
{
int counted_bars=IndicatorCounted();
int i,j,k,limit;
if(counted_bars<0) return(-1);
if(counted_bars>0) counted_bars--;
limit=MathMin(Bars-1,Bars-counted_bars+HalfLength);
if (returnBars) { buffer1[0] = limit+1; return(0); }
if (calculateValue || timeFrame==Period())
{
for (i=limit; i>=0; i--)
{
double sum = (HalfLength+1)*iMA(NULL,0,1,0,MODE_SMA,Price,i);
double sumw = (HalfLength+1);
for(j=1, k=HalfLength; j<=HalfLength; j++, k--)
{
sum += k*iMA(NULL,0,1,0,MODE_SMA,Price,i+j);
sumw += k;
if (j<=i)
{
sum += k*iMA(NULL,0,1,0,MODE_SMA,Price,i-j);
sumw += k;
}
}
double range = iATR(NULL,0,ATRPeriod,i+10)*ATRMultiplier;
buffer1[i] = sum/sumw;
buffer2[i] = buffer1[i]+range;
buffer3[i] = buffer1[i]-range;
trend[i] = 0;
if (alertsOnHighLow)
{
if (High[i] > buffer2[i]) trend[i] = 1;
if (Low[i] < buffer3[i]) trend[i] = -1;
}
else
{
if (Close[i] > buffer2[i]) trend[i] = 1;
if (Close[i] < buffer3[i]) trend[i] = -1;
}
}
if (!calculateValue) manageAlerts();
return(0);
}
limit = MathMax(limit,MathMin(Bars-1,iCustom(NULL,timeFrame,indicatorFileName,"returnBars",0,0)*timeFrame/Period()));
for(i=limit; i>=0; i--)
{
int y = iBarShift(NULL,timeFrame,Time[i]);
buffer1[i] = iCustom(NULL,timeFrame,indicatorFileName,"calculateTma",HalfLength,Price,ATRMultiplier,ATRPeriod,0,y);
buffer2[i] = iCustom(NULL,timeFrame,indicatorFileName,"calculateTma",HalfLength,Price,ATRMultiplier,ATRPeriod,1,y);
buffer3[i] = iCustom(NULL,timeFrame,indicatorFileName,"calculateTma",HalfLength,Price,ATRMultiplier,ATRPeriod,2,y);
trend[i] = iCustom(NULL,timeFrame,indicatorFileName,"calculateTma",HalfLength,Price,ATRMultiplier,ATRPeriod,3,y);
if (timeFrame <= Period() || y==iBarShift(NULL,timeFrame,Time[i-1])) continue;
if (!Interpolate) continue;
datetime time = iTime(NULL,timeFrame,y);
for(int n = 1; i+n < Bars && Time[i+n] >= time; n++) continue;
for(k = 1; k < n; k++)
{
buffer1[i+k] = buffer1[i] +(buffer1[i+n]-buffer1[i])*k/n;
buffer2[i+k] = buffer2[i] +(buffer2[i+n]-buffer2[i])*k/n;
buffer3[i+k] = buffer3[i] +(buffer3[i+n]-buffer3[i])*k/n;
}
}
manageAlerts();
return(0);
}
//+-------------------------------------------------------------------
//|
//+-------------------------------------------------------------------
void manageAlerts()
{
if (alertsOn)
{
if (alertsOnCurrent)
int whichBar = 0;
else whichBar = 1; whichBar = iBarShift(NULL,0,iTime(NULL,timeFrame,whichBar));
if (trend[whichBar] != trend[whichBar+1])
{
if (trend[whichBar] == 1) doAlert(whichBar,"up");
if (trend[whichBar] ==-1) doAlert(whichBar,"down");
}
}
}
//
void doAlert(int forBar, string doWhat)
{
static string previousAlert="nothing";
static datetime previousTime;
string message;
if (previousAlert != doWhat || previousTime != Time[forBar]) {
previousAlert = doWhat;
previousTime = Time[forBar];
message = StringConcatenate(Symbol()," at ",TimeToStr(TimeLocal(),TIME_SECONDS)," "+timeFrameToString(timeFrame)+" TMA bands price penetrated ",doWhat," band");
if (alertsMessage) Alert(message);
if (alertsEmail) SendMail(StringConcatenate(Symbol(),"TMA bands "),message);
if (alertsSound) PlaySound("alert2.wav");
}
}
//+-------------------------------------------------------------------
//|
//+-------------------------------------------------------------------
string sTfTable[] = {"M1","M5","M15","M30","H1","H4","D1","W1","MN"};
int iTfTable[] = {1,5,15,30,60,240,1440,10080,43200};
int stringToTimeFrame(string tfs)
{
tfs = StringUpperCase(tfs);
for (int i=ArraySize(iTfTable)-1; i>=0; i--)
if (tfs==sTfTable[i] || tfs==""+iTfTable[i]) return(MathMax(iTfTable[i],Period()));
return(Period());
}
string timeFrameToString(int tf)
{
for (int i=ArraySize(iTfTable)-1; i>=0; i--)
if (tf==iTfTable[i]) return(sTfTable[i]);
return("");
}
string StringUpperCase(string str)
{
string s = str;
for (int length=StringLen(str)-1; length>=0; length--)
{
int char_code = StringGetChar(s, length);
if((char_code > 96 && char_code < 123) || (char_code > 223 && char_code < 256))
s = StringSetChar(s, length, char_code - 32);
else if(char_code > -33 && char_code < 0)
s = StringSetChar(s, length, char_code + 224);
}
return(s);
}
and here the cTrader Code i would like to adapt but i do not see what i miss, result is not the same ( i exclude alerts functions of the MT4 code) :
using System;
using cAlgo.API;
using cAlgo.API.Internals;
using cAlgo.API.Indicators;
using cAlgo.Indicators;
namespace cAlgo
{
[Indicator(IsOverlay = true, TimeZone = TimeZones.UTC, AccessRights = AccessRights.None)]
public class TMABands : Indicator
{
[Parameter(DefaultValue = 60, MinValue = 1)]
public int HalfLength { get; set; }
[Parameter()]
public DataSeries Price { get; set; }
[Parameter(DefaultValue = 2.5)]
public double ATRMultiplier { get; set; }
[Parameter(DefaultValue = 100)]
public int ATRPeriod { get; set; }
[Output("Center", LineColor = "white", PlotType = PlotType.Points)]
public IndicatorDataSeries Center { get; set; }
[Output("Upper", LineColor = "white")]
public IndicatorDataSeries Upper { get; set; }
[Output("Lower", LineColor = "white")]
public IndicatorDataSeries Lower { get; set; }
private AverageTrueRange _atr;
protected override void Initialize()
{
_atr = Indicators.AverageTrueRange(ATRPeriod, MovingAverageType.Simple);
}
public override void Calculate(int index)
{
if (index < HalfLength)
return;
double sum = (HalfLength + 1) * Price[index];
double sumw = (HalfLength + 1);
for (int j = 1, k = HalfLength; j <= HalfLength; j++,k--)
{
sum += k * Price[index - j];
sumw += k;
}
double range = _atr.Result[index - 10] * ATRMultiplier;
Center[index] = sum / sumw;
Upper[index] = Center[index] + range;
Lower[index] = Center[index] - range;
}
}
}
Anyone could help me please ?
thanks & regards,
Alex
PanagiotisCharalampous
17 Jun 2021, 08:05
Hi Nobody,
There are a couple of then available for cTrader. Did you try them?
https://ctrader.com/algos/indicators/show/295
https://ctrader.com/algos/indicators/show/2531
Best Regards,
Panagiotis
Join us on Telegram and Facebook
@PanagiotisCharalampous