Close Positions when Price closes above SMA

Delta_Gamma
03 Jun 2013, 10:13

Hi just noticed an error, I copied and pasted the wrong code, it should be MA1 not HG:

private void OpenPosition()
        {
            foreach (var position in Account.Positions)
            {
                if (MarketSeries.Close.HasCrossedAbove(MA1.Result.LastValue))
                {
                    ClosePosition();
                }
            }
        }  

Delta_Gamma
03 Jun 2013, 19:55 ( Updated at: 21 Dec 2023, 09:20 )

I would appreciate some feedback from the admin.

The attached pic explains what I need the program to do for clarity:

basically, (referring to the pic) I wanted that trade to close as soon as the price closed under the green line (which is a customised simple moving average indicator).

How would I code this?

Thanks

cAlgo_Fanatic
04 Jun 2013, 09:30

You may want to use the previous to the last value since the last value changes on each tick. Also, the code should probably go in the OnBar or OnTick event.

Delta_Gamma
04 Jun 2013, 12:38 ( Updated at: 21 Dec 2023, 09:20 )

Hi Admin,

Thanks for the response. By previous to last value do you mean I make it LastValue-1 like this?

I tried this in a backtest and it didn't seem to close the trade. (attached pic)

Do you have any recommendations on what I can do to achieve this? I just need the trade to close when it either touches or closes above the SMA.

The attached pic has the area circled where I need the trade to close.

Thanks again.

protected override void OnTick()
        {

                     
                Buy();
                
                 foreach (var position in Account.Positions)
            
                if (MarketSeries.Close.HasCrossedAbove(MA1.Result.LastValue-1,0))
                {
                    ClosePosition();
        
                }

cAlgo_Fanatic
04 Jun 2013, 14:41

The functions HasCrossedAbove/HasCrossedBelow use a period parameter to determine whether one series has crossed above/below the other over a given period up to the last value. You may use these functions with a period greater than zero (period = 0 will only compare the last value, period = 1 will compare the last and previous to last values, etc. ) or just compare the previous to the last values of your series, depending on your desired solution.

To use the previous to the last determine the last index and apply it to the series:

var lastIndex = MarketSeries.Close.Count - 1;  // last index
var valueMa = MA1.Result[lastIndex - 1];      // previous to last MA1 value
var valueClose = MarketSeries.Close[lastIndex - 1];   // previous to last Close value

// compare the two values
if(valueClose >= valueMa)
{
  //... do something
}

Delta_Gamma
04 Jun 2013, 17:22

Hi,

Thanks very much for the help. It's working great now.

I just have to do some refinements and it should ready.

Thanks again.